Review Request 123195: fix various bugs related to footnotes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123195/#review78299
-----------------------------------------------------------

Ship it!


Cool!  Looks good.  I had a couple of questions that come more from not understanding all the details than finding anything wrong.  Check them and fix them if there is anything to fix, otherwise disregard them.


libs/kotext/KoInlineNote.cpp (line 98)
<https://git.reviewboard.kde.org/r/123195/#comment53612>

    What's the fallback if the style returned is 0? And under which circumstances can that happen?



libs/kotext/styles/KoStyleManager.cpp (line 154)
<https://git.reviewboard.kde.org/r/123195/#comment53613>

    Shouldn't there be some 'if ()'s around these that check if there already are default styles for footnotes etc? And regarding the anchors, shouldn't they be superscript by default?


- Inge Wallin


On March 31, 2015, 1:25 p.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123195/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 1:25 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The footnotes and endnotes were not displayed using the correct styles. We had just hard coded them to be shown using
>     superscript, but they should be done using the styles specified by the notes configuration.
>     
>     The same applies to the paragraph style of the note itself - but since this is just a default we didn't see any problem
>     when loading files, only when adding our own footnotes.
>     
>     Now netiher of the 3 styles specified by the notes configuraion needs to be present in files, and indeed are not present in
>     our templates, so what LO does is add some styles. We do the same with these 6 styles
>     
>     Footnote : based on default paragraph
>     Footnote Symbol : Applied to the id in the footnote itself - just a black text style
>     Footnote anchor : Applied to the id in the main text area - superscript
>     Endnote : based on default paragraph
>     Endnote Symbol : Applied to the id in the endnote itself - just a black text style
>     Endnote anchor : Applied to the id in the main text area - superscript
>     
>     BUG:306141
>     BUG:323232
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.cpp ec8f4d0 
>   libs/kotext/opendocument/KoTextSharedLoadingData.cpp 600ad37 
>   libs/kotext/styles/KoStyleManager.cpp dc8bdfd 
>   libs/odf/KoOdfNotesConfiguration.h 6395185 
>   libs/odf/KoOdfNotesConfiguration.cpp ae6d8ac 
>   libs/odf/KoOdfNumberDefinition.cpp 5670f9f 
>   libs/odf/KoOdfStylesReader.cpp 2c0f5b2 
>   libs/textlayout/KoTextLayoutNoteArea.cpp 0d1497d 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp 96aae3c 
> 
> Diff: https://git.reviewboard.kde.org/r/123195/diff/
> 
> 
> Testing
> -------
> 
> only manual testing
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150331/4aed8b64/attachment.htm>