Review Request 123166: Make combo-boxes in tables and forms show just one column

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123166/
-----------------------------------------------------------

(Updated March 29, 2015, 11:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Kamil Łysik, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Changes
-------

Submitted with commit 55758b4eaa64e1e9fa9321eb87bd6218e8f1596d by Jaroslaw Staniek to branch calligra/2.9.


Bugs: 345631
    http://bugs.kde.org/show_bug.cgi?id=345631


Repository: calligra


Description
-------

Make combo-boxes in tables and forms show just one column

Without this fix combo-boxes in tables and forms show all possible columns instead of just one but Kexi lets the user to define just one visible column. Even bound column (such as id) is presented, what results in an unpleasant look & feel.


Diffs
-----

  kexi/widget/tableview/kexicomboboxbase.h e128bb0a794998a1825b25fdad356fe3a9555d69 
  kexi/widget/tableview/kexicomboboxbase.cpp 6eab6a98a5be8909252e1e2e7c1b1f70289d49f8 
  kexi/widget/tableview/kexicomboboxpopup.cpp 0c87c065876ace6db373157b4b1e57950f47dea2 
  libs/db/lookupfieldschema.h d6d96ce606e9617cc5d43ad9a19275b3f0e770a9 
  libs/db/lookupfieldschema.cpp 0187c49e462496f702998ee824d3979d24861d23 

Diff: https://git.reviewboard.kde.org/r/123166/diff/


Testing
-------

Works with both tables and queries used as a combo box row source, for table view and form view


File Attachments
----------------

Query as a row source
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/cf98296f-c8e7-4e58-af1e-44ad24909162__query-row-source.png


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150329/df207e45/attachment.htm>