Review Request 123004: Krita - Fix the filter dialog by adding a togglebutton to show/hide the filtertree

Moritz Molch kde at moritzmolch.de
Sat Mar 28 17:53:41 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123004/
-----------------------------------------------------------

(Updated March 28, 2015, 5:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Changes
-------

Submitted with commit 43c4f646a832b78c5d17f1ff563875bc2623d709 by Moritz Molch to branch calligra/2.9.


Repository: calligra


Description
-------

This patch fixes the ability to show/hide the filtertree in the filterdialogs. I also did a small relayout by putting the buttons in one line at the bottom and grouping them in a reasonable way.

The attached file sidebaricon.png has to be placed inside the "krita/pics" directory when applying this patch.


Diffs
-----

  krita/ui/widgets/kis_filter_selector_widget.h 5c4c4e2 
  krita/ui/widgets/kis_filter_selector_widget.cc 2fc1ab7 
  krita/ui/dialogs/kis_dlg_adjustment_layer.h aa50ef7 
  krita/ui/dialogs/kis_dlg_adjustment_layer.cc 7598671 
  krita/ui/dialogs/kis_dlg_filter.h 7435c76 
  krita/ui/dialogs/kis_dlg_filter.cpp 1b54585 
  krita/ui/forms/wdgfilterdialog.ui 65c4275 
  krita/ui/forms/wdgfilternodecreation.ui 5a3698f 
  krita/pics/CMakeLists.txt 14e52f3 

Diff: https://git.reviewboard.kde.org/r/123004/diff/


Testing
-------

Tested on Ubuntu 14.04


File Attachments
----------------

sidebaricon.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/18/7d718b28-9607-4a63-b5a2-017fece2045c__sidebaricon.png
filterdialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/18/00b2b1dd-f86e-470d-8be1-61ab584ecf89__filterdialog.png
filterdialog_browse
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/18/ab3b65b4-5041-4083-9d0c-bcb4391ed85b__filterdialog_browse.png


Thanks,

Moritz Molch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150328/4cae0bbc/attachment.htm>


More information about the calligra-devel mailing list