Review Request 119224: Fix Krita speed sensor
Sven Langkamp
sven.langkamp at gmail.com
Sat Mar 28 10:11:06 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119224/
-----------------------------------------------------------
(Updated March 28, 2015, 10:11 a.m.)
Status
------
This change has been discarded.
Review request for Calligra, Dmitry Kazakov and Boudewijn Rempt.
Bugs: 325423
http://bugs.kde.org/show_bug.cgi?id=325423
Repository: calligra
Description
-------
The speed sensor is currently broken. The problem is that the speed is calculated with the distance and time difference each dab and the previous one. When the space between the dabs becomes to small the calculation breakes and falls back to a constant value.
The patch fixes the problem by calculating the speed of every event and then interpolating the speed between them. It also makes sure that there a minimum time difference between the measurements.
Diffs
-----
krita/image/brushengine/kis_paint_information.h 9b3be8f
krita/image/brushengine/kis_paint_information.cc 952f51f
krita/ui/tool/kis_painting_information_builder.h 993c25b
krita/ui/tool/kis_painting_information_builder.cpp 6e3d19a
Diff: https://git.reviewboard.kde.org/r/119224/diff/
Testing
-------
Tested by painting in Krita and appears to work. Needs further testing to see if it gives the expected results.
Thanks,
Sven Langkamp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150328/4d06a7b9/attachment.htm>
More information about the calligra-devel
mailing list