Review Request 119314: A set-able read only mode for Tagging Manager.

[Boudewijn Rempt]

> On Oct. 15, 2014, 5:04 p.m., Boudewijn Rempt wrote:
> > This already looks ok to me -- what is incomplete here? When I first saw 'incomplete' I thought I'd wait until an update would say it was a complete patch :-). Do you want to push this?

Ping again? Please push the patch :-)


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119314/#review68484
-----------------------------------------------------------


On July 16, 2014, 11:18 a.m., Sascha Suelzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119314/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 11:18 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This is an *incomplete*, but working change, originally part of a bigger refactoring to make the Favorite Preset Manager a bit nicer to use by allowing filtering for the All Presets View, and optionally the user defined Tag groups.
> 
> However, due to a lack of signals there was some trouble.
> 
> When a resource was selected it enabled the Add To Favorites button, but when the tag group was changed, invalidating the resource, the Add To Favorites button was still enabled, leading to a crash when pressed. 
> 
> Anyway, the part that works implements a set-able read only mode for the Tagging Manager which, when Tag modification is disallowed, will hide the TagToolButton to create, rename or delete Tag groups, disable the context menu and disallow change in the members of a Tag group, but allows to filter the Tag group.
> 
> 
> For example, a Tag group called erasers, with only erasers in it, would allow filtering with search terms, but there would not be a save button and pressing enter or clearing the search box would revert to showing only the original erasers in the Tag group.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoResourceTaggingManager.h 4f43667 
>   libs/widgets/KoResourceTaggingManager.cpp 3cffe5c 
>   libs/widgets/KoTagChooserWidget.h 55029d6 
>   libs/widgets/KoTagChooserWidget.cpp 0306805 
> 
> Diff: https://git.reviewboard.kde.org/r/119314/diff/
> 
> 
> Testing
> -------
> 
> I tested it by modifying the constructor of KoResourceItemChooser.cpp, adding a d->tagManager->allowTagModification(false); at the bottom.
> 
> 
> Thanks,
> 
> Sascha Suelzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150328/45db42a6/attachment.htm>