Review Request 122946: Krita - Move labels into the sliders, make them dpi dependent

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122946/#review78141
-----------------------------------------------------------

Ship it!


- Boudewijn Rempt


On March 14, 2015, 1:55 p.m., Moritz Molch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122946/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 1:55 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch moves the labels into the sliders in the main UI and makes the minimal width dpi dependent to give them a reasonable size on high resolution screens. It also fixes the "two line issue" in the sliders.
> 
> The slider labels can be disabled by adding the line
> sliderLabels=false
> to the config at the moment.
> 
> It is good UI design to have elements that belong together also visually grouped together because it's easier for the eyes to parse, so it makes perfectly sense (that's also one of the reasons why gimp, blender and lots of other applications are doing this, it's not really about saving space)
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp db1728c 
>   krita/ui/kis_config.h 31cc94d 
>   krita/ui/kis_config.cc 27dca2d 
>   krita/ui/kis_paintop_box.cc b1135d7 
>   krita/ui/widgets/kis_cmb_composite.cc 9d54f74 
>   krita/ui/widgets/kis_slider_spin_box.h 4ce641a 
>   krita/ui/widgets/kis_slider_spin_box.cpp 59f6b78 
>   krita/ui/widgets/kis_widget_chooser.h 5f7528b 
>   krita/ui/widgets/kis_widget_chooser.cpp 3a699a8 
> 
> Diff: https://git.reviewboard.kde.org/r/122946/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Moritz Molch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150328/338520c7/attachment.htm>