Review Request 123157: Prevent crash when removing elements in WidgetTreeWidget
Jarosław Staniek
staniek at kde.org
Fri Mar 27 23:34:37 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123157/#review78128
-----------------------------------------------------------
Ship it!
Good!
Note: Message like this would be a bit better:
"Prevent crash when removing elements in Kexi forms object tree"
(it refers to Kexi and names the UI element in terms of design instead of implementation; the latter is clear from the lecture of the patch)
- Jarosław Staniek
On March 28, 2015, 12:30 a.m., Kamil Łysik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123157/
> -----------------------------------------------------------
>
> (Updated March 28, 2015, 12:30 a.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 345336
> http://bugs.kde.org/show_bug.cgi?id=345336
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Prevent crash when removing elements in WidgetTreeWidget
>
> BUG:345336
>
>
> Diffs
> -----
>
> kexi/formeditor/WidgetTreeWidget.cpp 5869fdb
>
> Diff: https://git.reviewboard.kde.org/r/123157/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kamil Łysik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150327/90a70211/attachment.htm>
More information about the calligra-devel
mailing list