Review Request 123146: calligra sheets: do not use VerPattern twice for cell pattern

[Boris Egorov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123146/
-----------------------------------------------------------

(Updated March 27, 2015, 7:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Changes
-------

Submitted with commit 03b6b1501a20a97cd03c8a670d4852e4abc31faf by Boris Egorov to branch master.


Repository: calligra


Description
-------

Do not use VerPattern twice for cell pattern

There are two brush entries with VerPattern style used for cell format.
Change one of them to SolidPattern style (the only unused BrushStyle for
cell pattern). See image: http://i.imgur.com/JGtP5Ew.png

Issue detected by Cppcheck: "[sheets/dialogs/LayoutDialog.cpp:3456]:
Expression is always false because 'else if' condition matches previous
condition at line 3432."


Diffs
-----

  sheets/dialogs/LayoutDialog.cpp 48ec5e6 

Diff: https://git.reviewboard.kde.org/r/123146/diff/


Testing
-------

Build Calligra, run Sheets, try to use SolidPattern for cell pattern.


Thanks,

Boris Egorov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150327/2ab876d1/attachment.htm>