Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi

Wojciech Kosowicz pcellix at gmail.com
Sun Mar 22 16:56:14 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/
-----------------------------------------------------------

(Updated March 22, 2015, 4:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Adam Pigg and Jarosław Staniek.


Changes
-------

Submitted with commit 91e20954d34e51f077733eceb9b4a812a2e34081 by Jaroslaw Staniek on behalf of Wojciech Kosowicz to branch master.


Repository: calligra


Description
-------

When hash sign (#) appears in csv file at the beginning of the line or in the middle of unqouted field
it is treated as the beginning of the comment and the following data is being ignored until the end of the row


Diffs
-----

  kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 
  kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd 
  kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 
  libs/widgets/KoCsvImportDialog.cpp 8d042d7 

Diff: https://git.reviewboard.kde.org/r/120940/diff/


Testing
-------

Able to activate/deactivate parsing comments. When activated able to choose specific sign


Thanks,

Wojciech Kosowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150322/8c519384/attachment.htm>


More information about the calligra-devel mailing list