Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter
Thorsten Zachmann
t.zachmann at zagge.de
Tue Mar 10 04:35:18 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122867/#review77243
-----------------------------------------------------------
Ship it!
The patch looks good to me.
- Thorsten Zachmann
On March 9, 2015, 11:52 a.m., Robert Mathias Marmorstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122867/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 11:52 a.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> The strstream class has been deprecated for some time in favor of the sstream classes. This patch replaces strstream with sstreams.
>
>
> Diffs
> -----
>
> filters/sheets/qpro/libqpro/src/formula.cc c5d6021
> filters/sheets/qpro/libqpro/src/record.cc bde5e7d
> filters/sheets/qpro/libqpro/src/stream.cc 4126aee
>
> Diff: https://git.reviewboard.kde.org/r/122867/diff/
>
>
> Testing
> -------
>
> After the change calligra compiles and passes the same unit tests as before. Unfortunately, I don't have any qpro files lying around to test this on.
>
>
> Thanks,
>
> Robert Mathias Marmorstein
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150310/8945e1c0/attachment.htm>
More information about the calligra-devel
mailing list