Review Request 122858: Krita - UI fixes and improvements

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122858/#review77201
-----------------------------------------------------------



krita/ui/widgets/kis_filter_selector_widget.cc
<https://git.reviewboard.kde.org/r/122858/#comment53028>

    Is this commented-out code intentional? Probably it should go?



krita/ui/widgets/kis_filter_selector_widget.cc
<https://git.reviewboard.kde.org/r/122858/#comment53029>

    Should this also be deleted?


- Dmitry Kazakov


On Март 8, 2015, 6:52 п.п., Moritz Molch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122858/
> -----------------------------------------------------------
> 
> (Updated Март 8, 2015, 6:52 п.п.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch fixes some UI related bugs and improves the usability especially for new / casual users like myself by removing some clutter and bringing in some consistency.
> 
> I detail it modifies:
> 
> * Create filter layer / Filter Mask
>   This fixes the treeview, slightly changes the layout and adds a scrollarea
>   to be usable on smaller screens, changes "Name" label to "Layer Name" to be
>   consistent with the "create fill layer" and "create file layer" widgets,
>   disables the preset buttons when the filter has no configuration
>   
> * Create fill layer
>   Fix resizing of the pattern widget, and removes unnecessary pattern label
>   
> * Remove unnecessary "Tag:" label and set it as the tooltip in TagChooserWidget.
>   By default the entry says "All presets", so the user already knows what it does.
>   This also adds to consistency with most other dropdowns in the interface
>   
> * Removed the statustip from the "Duplicate Layer or Mask" button in the layer docker.
>   This is the only button in krita that has it set and it's annoying to see the statusbar
>   flash each time you hover over that one button. Also the info is already in the tooltip.
> 
> 
> Kind regards,
> Moritz
> 
> 
> Diffs
> -----
> 
>   krita/plugins/generators/pattern/wdgpatternoptions.ui f92a7ec 
>   krita/ui/forms/wdgdlggeneratorlayer.ui d80a98d 
>   krita/ui/forms/wdgfilternodecreation.ui c616feb 
>   krita/ui/forms/wdgfilterselector.ui 405722b 
>   krita/ui/forms/wdggenerators.ui e9ffca8 
>   krita/ui/widgets/kis_filter_selector_widget.h 360aa67 
>   krita/ui/widgets/kis_filter_selector_widget.cc a16abd8 
>   libs/widgets/KoTagChooserWidget.cpp a625a1a 
>   krita/plugins/extensions/dockers/defaultdockers/wdglayerbox.ui d38262e 
>   krita/plugins/generators/pattern/kis_wdg_pattern.cpp c75d20c 
> 
> Diff: https://git.reviewboard.kde.org/r/122858/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Moritz Molch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150309/6beb8f9e/attachment.htm>