Review Request 122753: [Krita] add the option to show/hide the title bars of the dockers to the settings menu

[Moritz Molch]

> On Feb. 28, 2015, 1:42 p.m., Camilla Boemann wrote:
> > shouldn't this feature be in all of of calligra ?
> > that said we are closed for features until 3.0 is released
> 
> Friedrich W. H. Kossebau wrote:
>     Would agree this should be a feature calligra wide.
>     
>     WRT featue freeze, if it is nice feature, small code change, and well reviewed, I would be for still letting that in. No rules without reasonable exceptions.
>     
>     Not yet looked at the code in detail, though.
> 
> Boudewijn Rempt wrote:
>     Maybe, maybe not. Calligra apps that use the sidebar instead of dockers probably don't need it. In any case, Krita no longer shares the komain and the mainwindow code with the rest of calligra, so if the rest of calligra wants this feature, it can be implemented -- but there's no need for Moritz to do that.
> 
> Friedrich W. H. Kossebau wrote:
>     No need, but would be great :) (Besides, the sidebar is not integrating all the dockers, there are still quite some normal ones also in those apps. And even hiding the titlebar of the sidebar would be nice to have).
>     So Moritz, do you think you could give it a try to also do this patch for the KoMainWindow-based code?
> 
> Boudewijn Rempt wrote:
>     If that scratches an itch, why not, but let this be clear: there is absolutely no obligation whatsoever.
> 
> Moritz Molch wrote:
>     Thank you for your replies.
>     I added the changes to the KoMainWindow and it seems to work very well. I only tested with karbon though because compiling takes quite a long time on my 7 year old but absolutely silent machine, so I updated the patch with certain reserves because it really should be tested with all the depending applications.
>     Kind regards
> 
> Friedrich W. H. Kossebau wrote:
>     Hi Moritz. Thanks for that :) Was about to test it, but looks like the patch update has not yet made it completely onto reviewboard. Guess there is another button still waiting for your confirm to update this review request?

Oh, sorry for that. Somehow I seem to have overlooked that big green bar at the top with the "Publish changes" button :-)
I took a look at the "view diff" tab and since all the changes showed up there I thought it was already there.


- Moritz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122753/#review76765
-----------------------------------------------------------


On March 1, 2015, 10:51 p.m., Moritz Molch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122753/
> -----------------------------------------------------------
> 
> (Updated March 1, 2015, 10:51 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Inspired by kdenlive, this small patch adds the option to show/hide the titlebars of all dockers to the settings menu.
> 
> 
> Diffs
> -----
> 
>   krita/krita.action b683185 
>   krita/krita.rc 0ec0931 
>   krita/ui/KisMainWindow.h 9cdcce5 
>   krita/ui/KisMainWindow.cpp e8c6009 
>   krita/ui/kis_config.h b6852de 
>   krita/ui/kis_config.cc a09c7b8 
>   libs/main/KoMainWindow.h ac6cc82 
>   libs/main/KoMainWindow.cpp b66fb49 
>   libs/main/calligra_shell.rc 3f09d7e 
>   libs/widgets/KoDockWidgetTitleBar.cpp cf0c722 
> 
> Diff: https://git.reviewboard.kde.org/r/122753/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu 14.04
> 
> 
> Thanks,
> 
> Moritz Molch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150301/2ac62431/attachment.htm>