Question about Calligra branches for Phabricator revisions

[Jaroslaw Staniek]

On 21 June 2015 at 22:45, Ben Cooksley <bcooksley at kde.org> wrote:
> On Mon, Jun 22, 2015 at 7:18 AM, Jaroslaw Staniek <staniek at kde.org> wrote:
>> On 21 June 2015 at 10:44, Ben Cooksley <bcooksley at kde.org> wrote:
>>>>
>>>> @Ben I think the list is complete: master, calligra/x.y, frameworks.
>>>
>>> It should now be configured to do so.
>>> Autoclose Only: master, frameworks, regexp(/^calligra\//)
>>
>> Ben, thanks!
>> One thing that probably needs clarification. From the ticket TNK-3382,
>> your note:
>>
>> "Per my email this should now be resolved.
>> In regards to Arcanist, you can probably configure it to not add the
>> "Differential Revision" line."
>>
>> I'd like to ask what does it mean.
>
> What this means is:
>
> a) I've configured the autoclose branches as requested.
>
> b) For future reference, Arcanist can probably be configured to not
> alter the commit message when landing commits. This would avoid
> autoclosing if you don't want to when landing into an autoclose
> branch.

Thanks. I used this approach on a work branch recently (before you
reduced the scope of autoclose).
I think I used:
% arc diff --no-amend HEAD^

But this looks useful only for feature branches now, that have
autoclose disabled anyway. For autoclosing branches commit messages
are somewhat 'final', having them without the 'Differential Revision'
lines we loose references to revisions in the history.

>>
>> My assumption was that the line can be added (by hand or by Arcanist
>> or any such tool) to the commit message and still the non-autoclosing
>> branches won't react (the Differential won't close the review).
>>
>
> Regards,
> Ben
>
>> --
>> regards, Jaroslaw Staniek
>>
>> KDE:
>> : A world-wide network of software engineers, artists, writers, translators
>> : and facilitators committed to Free Software development - http://kde.org
>> Calligra Suite:
>> : A graphic art and office suite - http://calligra.org
>> Kexi:
>> : A visual database apps builder - http://calligra.org/kexi
>> Qt Certified Specialist:
>> : http://www.linkedin.com/in/jstaniek



-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek