Question about Calligra branches for Phabricator revisions

[Ben Cooksley]

On Sat, Jun 20, 2015 at 10:47 AM, Jaroslaw Staniek <staniek at kde.org> wrote:
> On 18 June 2015 at 10:30, Boudewijn Rempt <boud at valdyas.org> wrote:
>> On Thu, 18 Jun 2015, Jaroslaw Staniek wrote:
>>
>>> Hi,
>>> We started to use/try phabricator for reviews, task management [1].
>>> During the KDE admins, namely Ben Cooksley, are more than helpful to
>>> tune things up to our workflows.
>>>
>>> The difference between it and the reviewboard.kde.org in that
>>> 'autocloses' revews (so-called revisions [2]) when a commit containing
>>> a 'Differential Revision:' line [3] in its message is pushed to the
>>> repo. This means immediate closing of the review. But we tend to push
>>> to a feature branch for facilitate code management: I personally would
>>> not want to keep commits locally and only publish diffs on phabricator
>>> during the review.
>>>
>>> After some chatting with Ben we have an idea that the auto-closing is
>>> good but it could be limited to some branches.
>>>
>>> Now the question is what these branches are for the calligra repo.
>>> My idea is: master, calligra/x.y. And maybe frameworks?
>>
>>
>> I think that's a good list. Frameworks needs to be included, since it looks
>> like it'll be living for some time yet.
>>
>
> @Ben I think the list is complete: master, calligra/x.y, frameworks.

It should now be configured to do so.
Autoclose Only: master, frameworks, regexp(/^calligra\//)

Regards,
Ben

>>
>>>
>>> Please comment on it within the 48h or so.
>>>
>>> PS: For new repos I am managing - kreport/kproperty/kdb - it's enough
>>> to have autoclose is only for master.
>>> PS: I know most can be lost as there's no official
>>> Calligra/KDE-specific HOWTO for the phabricator-based workflow; we
>>> need to have it all working for us first before recommending.
>>>
>>> [1] http://phabricator.kde.org/
>>> [2] https://secure.phabricator.com/book/phabricator/article/differential/
>>> (nice command-line function available using arcanist)
>>> [3] Example of such a commit:
>>> http://comments.gmane.org/gmane.comp.kde.cvs/1421533
>>> --
>>> regards, Jaroslaw Staniek
>>>
>>> KDE:
>>> : A world-wide network of software engineers, artists, writers,
>>> translators
>>> : and facilitators committed to Free Software development - http://kde.org
>>> Calligra Suite:
>>> : A graphic art and office suite - http://calligra.org
>>> Kexi:
>>> : A visual database apps builder - http://calligra.org/kexi
>>> Qt Certified Specialist:
>>> : http://www.linkedin.com/in/jstaniek
>>> _______________________________________________
>>> calligra-devel mailing list
>>> calligra-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/calligra-devel
>>
>> _______________________________________________
>> calligra-devel mailing list
>> calligra-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/calligra-devel
>
>
>
> --
> regards, Jaroslaw Staniek
>
> KDE:
> : A world-wide network of software engineers, artists, writers, translators
> : and facilitators committed to Free Software development - http://kde.org
> Calligra Suite:
> : A graphic art and office suite - http://calligra.org
> Kexi:
> : A visual database apps builder - http://calligra.org/kexi
> Qt Certified Specialist:
> : http://www.linkedin.com/in/jstaniek