Review Request 124034: Fixes an issue where the installed kritarc is not used

[Victor Wåhlström]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124034/
-----------------------------------------------------------

(Updated June 9, 2015, 1:03 p.m.)


Review request for Calligra.


Changes
-------

Moved to KoGlobal. This may fix similar bugs elsewhere, but may also introduce other bugs if not careful. I added a comment to the code and will add a comment to the commit message so it's easier to track down the cause. The potential bug should only happen if someone writes settings before KoGlobal::initialize() without writing the settings to disk, which should not happen as it's a bad idea to write settings before all core systems have been initialized.


Repository: calligra


Description
-------

For some reason KGlobal::config() is constructed before all paths have been added. This results in fallback kritarc files not being parsed at startup. Side effects include bad initial UI layout, and blacklisted tools showing up in the toolbox. This patch forces KGlobal::config() to reconsider all config files on disk after paths have been added.


Diffs (updated)
-----

  libs/widgets/KoGlobal.cpp f68f314e 

Diff: https://git.reviewboard.kde.org/r/124034/diff/


Testing
-------

Tests done on Kubuntu 15.04

Closed Krita, removed user version of kritarc (~/.kde/share/config/kritarc), started Krita without the patch, observed bad layout and tools which shouldn't be in the toolbox.

Closed Krita, removed user version of kritarc (~/.kde/share/config/kritarc), started Krita with the patch, observed good default layout and expected tools in toolbox.


Thanks,

Victor Wåhlström

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150609/5a2c1796/attachment.htm>