Review Request 123985: Port sheets' configure dialog to KF5

Tomas Mecir mecirt at gmail.com
Tue Jun 2 19:20:19 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123985/#review81087
-----------------------------------------------------------


compiling to check, but at a glance, I don't think the plugin stuff is going to work, as function modules are loaded using KoJsonTrader in the KDE5 version, as the comments indicate (see sheets/FunctionModuleRegistry.cpp).

- Tomas Mecir


On jún 2, 2015, 4:08 popoludní, Peter Simonsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123985/
> -----------------------------------------------------------
> 
> (Updated jún 2, 2015, 4:08 popoludní)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix buttons and signals.
> ?eenable the plugin selector.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a4e3f24 
>   sheets/CMakeLists.txt c7567c4 
>   sheets/part/dialogs/PreferenceDialog.h 543bf45 
>   sheets/part/dialogs/PreferenceDialog.cpp 8b044a8 
> 
> Diff: https://git.reviewboard.kde.org/r/123985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Peter Simonsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150602/fc8e866b/attachment.htm>


More information about the calligra-devel mailing list