Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly

[Camilla Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124508/#review83093
-----------------------------------------------------------


Looks generally good


libs/kotext/KoTextEditor.cpp (line 438)
<https://git.reviewboard.kde.org/r/124508/#comment57371>

    partly argument should be true in this case I think


- Camilla Boemann


On July 28, 2015, 1:30 p.m., Soma Schliszka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124508/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 1:30 p.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The KoTextVisitor is extended with two empty virtual functions. These will allow to perform custom operation when visiting a QTextTable or QTextTableCell object.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.cpp c6e0976 
>   libs/kotext/KoTextEditor_p.h 93f7e67 
> 
> Diff: https://git.reviewboard.kde.org/r/124508/diff/
> 
> 
> Testing
> -------
> 
> Builded successfully, empty virtual functions so they do nothing during execution.
> 
> 
> Thanks,
> 
> Soma Schliszka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150728/f18e1d83/attachment.htm>