Review Request 124508: Extending KoTextVisitor to handle table and cell visiting customly
Denis Kuplyakov
dener.kup at gmail.com
Tue Jul 28 14:43:33 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124508/#review83094
-----------------------------------------------------------
libs/kotext/KoTextEditor_p.h (line 103)
<https://git.reviewboard.kde.org/r/124508/#comment57372>
I think, you should replace this bool to some enum (VisitTableMode??). That will make code more readable.
- Denis Kuplyakov
On Июль 28, 2015, 1:30 п.п., Soma Schliszka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124508/
> -----------------------------------------------------------
>
> (Updated Июль 28, 2015, 1:30 п.п.)
>
>
> Review request for Calligra and Camilla Boemann.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> The KoTextVisitor is extended with two empty virtual functions. These will allow to perform custom operation when visiting a QTextTable or QTextTableCell object.
>
>
> Diffs
> -----
>
> libs/kotext/KoTextEditor.cpp c6e0976
> libs/kotext/KoTextEditor_p.h 93f7e67
>
> Diff: https://git.reviewboard.kde.org/r/124508/diff/
>
>
> Testing
> -------
>
> Builded successfully, empty virtual functions so they do nothing during execution.
>
>
> Thanks,
>
> Soma Schliszka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150728/eab7bcc0/attachment.htm>
More information about the calligra-devel
mailing list