Review Request 124291: Loop optimalization at table cell formatting

Thorsten Zachmann t.zachmann at zagge.de
Thu Jul 16 04:50:20 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124291/#review82560
-----------------------------------------------------------

Ship it!


Looks good please commit.

- Thorsten Zachmann


On July 8, 2015, 9:10 a.m., Soma Schliszka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124291/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 9:10 a.m.)
> 
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> It is not necessary to create the style definition in every iteration just apply a predefined one. 
> Thus the formatting configuration is moved out from the loop.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoTextEditor.cpp 7191db5 
> 
> Diff: https://git.reviewboard.kde.org/r/124291/diff/
> 
> 
> Testing
> -------
> 
> Builded successfully
> 
> 
> Thanks,
> 
> Soma Schliszka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150716/e5cda955/attachment.htm>


More information about the calligra-devel mailing list