Review Request 122306: Fix bug 260088 - assert when ungrouping group

Camilla Boemann cbr at boemann.dk
Thu Jan 29 15:20:05 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122306/#review74986
-----------------------------------------------------------

Ship it!


Ship It!

- Camilla Boemann


On Jan. 29, 2015, 3:08 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122306/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 3:08 p.m.)
> 
> 
> Review request for Calligra, Elvis Stansvik and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch makes Words not crash anymore.
> 
> But it's not the full solution because after the ungrouping the shapes behave very strange when you select them and try to use "Shape properties" in the context menu. I thought I'd show this crash fix first, though and then estan can fix the strange behaviour since it's in his new code.
> 
> 
> Diffs
> -----
> 
>   words/part/KWView.cpp f20199a 
> 
> Diff: https://git.reviewboard.kde.org/r/122306/diff/
> 
> 
> Testing
> -------
> 
> manual testing according to the bug report.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150129/a0774408/attachment.htm>


More information about the calligra-devel mailing list