Review Request 122284: fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122284/#review74883
-----------------------------------------------------------


Hi, Aleksander!

I tested the patch. It works nicely. I have only one concern. Probably, it would be better to rename the option to something more specific, like "Hide layer thumbnail tooltip" or "Hide layer thumbnail popup" or something else? Right now it is a bit difficult to understand what the option means.

In the rest the patch is perfect, especially setntence-casing the checkboxes to fit KDE capitalization policy! :)

- Dmitry Kazakov


On Jan. 28, 2015, 4:59 a.m., Aleksander Demko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122284/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2015, 4:59 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 342168
>     http://bugs.kde.org/show_bug.cgi?id=342168
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> fixed Bug 342168 - JJ: A way to disable the "on hover" layer thumbnail popup.
> 
> Added a new global setting "Hide various popups", when enabled,
> suppresses all tooltip popups in KisDocumentSelectionDelegate
> 
> 
> Diffs
> -----
> 
>   krita/ui/KisDocumentSectionDelegate.cpp a827e06 
>   krita/ui/dialogs/kis_dlg_preferences.cc 1379e8b 
>   krita/ui/forms/wdgdisplaysettings.ui 751ee50 
>   krita/ui/kis_config.h bbb3242 
>   krita/ui/kis_config.cc f67c08d 
> 
> Diff: https://git.reviewboard.kde.org/r/122284/diff/
> 
> 
> Testing
> -------
> 
> Basic developer testing.
> 
> 
> Thanks,
> 
> Aleksander Demko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150128/ebf9b086/attachment.htm>