Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122266/#review74821
-----------------------------------------------------------

Ship it!


Ok, all of my questions have been answered so I'm satisfied.

- Inge Wallin


On Jan. 27, 2015, 10:48 a.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122266/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 10:48 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> split kwrootareaprovider in 3 classes for better overview and solving text flwing between textboxes
> 
> 
> Diffs
> -----
> 
>   words/part/frames/KWTextFrameSet.cpp c8ccdb9 
>   words/part/KWRootAreaProviderBase.cpp PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.h PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.cpp PRE-CREATION 
>   words/part/frames/KWFrame.cpp f88f902 
>   words/part/frames/KWTextFrameSet.h 9106758 
>   words/part/CMakeLists.txt 386431e 
>   words/part/KWRootAreaProvider.h 54deaf3 
>   words/part/KWRootAreaProvider.cpp d26f519 
>   words/part/KWRootAreaProviderBase.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122266/diff/
> 
> 
> Testing
> -------
> 
> ran cstester and did some manual testing, but should eally do it again
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150127/b03716f7/attachment.htm>