Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

[Camilla Boemann]

> On Jan. 26, 2015, 11:38 p.m., Inge Wallin wrote:
> > words/part/KWRootAreaProviderBase.cpp, line 64
> > <https://git.reviewboard.kde.org/r/122266/diff/1/?file=345325#file345325line64>
> >
> >     This needs to be handled by a method in KoBorder.  But this is not enough, is it?  I see you take care about padding below, but you also need to take into account margin, right?
> 
> Camilla Boemann wrote:
>     a utility method in KoBorder would be nice yes, but this is okay for me though.
>     
>     Margin is handled inside the library iirc, but I am actually a little uncertain

page margins are handled in KWFrameLAyout and is outside the scope of this class.
Margins of the paragraphs are handled in the textlayout library - i just confirmed


- Camilla


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122266/#review74797
-----------------------------------------------------------


On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122266/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 11:17 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> split kwrootareaprovider in 3 classes for better overview and solving text flwing between textboxes
> 
> 
> Diffs
> -----
> 
>   words/part/CMakeLists.txt 386431e 
>   words/part/KWRootAreaProvider.h 54deaf3 
>   words/part/KWRootAreaProvider.cpp d26f519 
>   words/part/KWRootAreaProviderBase.h PRE-CREATION 
>   words/part/KWRootAreaProviderBase.cpp PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.h PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.cpp PRE-CREATION 
>   words/part/frames/KWFrame.cpp f88f902 
>   words/part/frames/KWTextFrameSet.h 9106758 
>   words/part/frames/KWTextFrameSet.cpp c8ccdb9 
> 
> Diff: https://git.reviewboard.kde.org/r/122266/diff/
> 
> 
> Testing
> -------
> 
> ran cstester and did some manual testing, but should eally do it again
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150127/0830c8c0/attachment.htm>