Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

[Camilla Boemann]

> On Jan. 27, 2015, 3:31 a.m., Thorsten Zachmann wrote:
> > words/part/KWRootAreaProviderBase.h, line 24
> > <https://git.reviewboard.kde.org/r/122266/diff/1/?file=345324#file345324line24>
> >
> >     There is also a root area provider outside of words. And I guess this handles words specific stuff that can't be done in the generic one.

yes indeed. This base class is more about sharing stuff among the words subclasses, than some general stuff that is useful outside words.

The class in libs/textlayout is an interface, and a basic implementation is available in textshape/SimpleRootAreaProvider

The words classes are dealing with flow and pages (in the wordprocessor sense)


- Camilla


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122266/#review74799
-----------------------------------------------------------


On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122266/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 11:17 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> split kwrootareaprovider in 3 classes for better overview and solving text flwing between textboxes
> 
> 
> Diffs
> -----
> 
>   words/part/CMakeLists.txt 386431e 
>   words/part/KWRootAreaProvider.h 54deaf3 
>   words/part/KWRootAreaProvider.cpp d26f519 
>   words/part/KWRootAreaProviderBase.h PRE-CREATION 
>   words/part/KWRootAreaProviderBase.cpp PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.h PRE-CREATION 
>   words/part/KWRootAreaProviderTextBox.cpp PRE-CREATION 
>   words/part/frames/KWFrame.cpp f88f902 
>   words/part/frames/KWTextFrameSet.h 9106758 
>   words/part/frames/KWTextFrameSet.cpp c8ccdb9 
> 
> Diff: https://git.reviewboard.kde.org/r/122266/diff/
> 
> 
> Testing
> -------
> 
> ran cstester and did some manual testing, but should eally do it again
> 
> 
> Thanks,
> 
> Camilla Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150127/a8786af6/attachment.htm>