Review Request 122240: Improve Kexi data-aware cell editing API

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122240/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 1:27 a.m.)


Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Changes
-------

Update to current calligra/2.9 644eddd5a26631


Repository: calligra


Description
-------

Improve Kexi data-aware cell editing API

Plus #1: table view's methods for [editor creation/column width change] now use specified column/row number instead of current ones.
Plus #2: in addNewRecordRequested() we're avoiding closing editor before cursor position gets changed (programatically) and avoiding ensuring cell visibility prior to creating the editor. This can enable implementing animations in the future.


Diffs (updated)
-----

  kexi/plugins/forms/kexiformscrollview.h 898490f 
  kexi/plugins/forms/kexiformscrollview.cpp 7771ba7 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.h c3f66cc 
  kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 5c47c10 
  kexi/widget/tableview/KexiTableScrollArea.h 836f5cc 
  kexi/widget/tableview/KexiTableScrollArea.cpp 0a06fc9 

Diff: https://git.reviewboard.kde.org/r/122240/diff/


Testing
-------

functionality of table views remain unchanged


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150126/c829fe09/attachment.htm>