Review Request 122035: Calligra filters: Enhance the odf reader library significantly

[Inge Wallin]

> On Jan. 17, 2015, 10:42 p.m., René J.V. Bertin wrote:
> > Applies without issues on OS X; any suggestions how to check/test the new functionality?
> 
> Inge Wallin wrote:
>     This are two parts to the patch:
>      1. Less code using smart macros to do the same as before.
>      2. More functionality in the library that is not yet used.
>     
>     To test #1 you can check with the filters that use this library that they are still producing the same output. This would be the docx and ascii export filters.  To test #2 you have to extend the filters.

Gah, rewriting sentences too much makes the end result seem really strange if you don't reread it all before posting.  :/


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122035/#review74201
-----------------------------------------------------------


On Jan. 13, 2015, 3:30 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122035/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 3:30 p.m.)
> 
> 
> Review request for Calligra, Lassi Nieminen and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Here is a little something that I hacked on in my sickbed. It's all very simple stuff, but I managed to accumulate quite a lot over the weeks.
> 
> Short summary:
>  - Some refactoring: a generic odf reader class
>  - New: support for ODS (spreadsheets)
>  - Support for many draw objects
>  - Support for frames
>  - Support for charts
>  - Much simplified code in the reader backend due to smart macros
> 
> There should be *no* API changes for external users of this library. This is tested using existing filters, mainly the docx export filter.
> 
> It would be nice to get this into master before we start on the qt5 port. The changes are limited to a very small part of the source tree and even though they are somewhat biggish, they are very simple in nature.
> 
> 
> Diffs
> -----
> 
>   filters/libodf2/CMakeLists.txt 3792771 
>   filters/libodf2/KoXmlStreamReader.h a06c8ec 
>   filters/libodf2/KoXmlUtils.h PRE-CREATION 
>   filters/libodf2/KoXmlUtils.cpp PRE-CREATION 
>   filters/libodfreader/CMakeLists.txt e4bfdda 
>   filters/libodfreader/OdfChartReader.h PRE-CREATION 
>   filters/libodfreader/OdfChartReader.cpp PRE-CREATION 
>   filters/libodfreader/OdfChartReaderBackend.h PRE-CREATION 
>   filters/libodfreader/OdfChartReaderBackend.cpp PRE-CREATION 
>   filters/libodfreader/OdfDrawReader.h PRE-CREATION 
>   filters/libodfreader/OdfDrawReader.cpp PRE-CREATION 
>   filters/libodfreader/OdfDrawReaderBackend.h PRE-CREATION 
>   filters/libodfreader/OdfDrawReaderBackend.cpp PRE-CREATION 
>   filters/libodfreader/OdfReader.h PRE-CREATION 
>   filters/libodfreader/OdfReader.cpp PRE-CREATION 
>   filters/libodfreader/OdfReaderBackend.h PRE-CREATION 
>   filters/libodfreader/OdfReaderBackend.cpp PRE-CREATION 
>   filters/libodfreader/OdfReaderInternals.h PRE-CREATION 
>   filters/libodfreader/OdfTextReader.h d6c5bc8 
>   filters/libodfreader/OdfTextReader.cpp ab6514d 
>   filters/libodfreader/OdfTextReaderBackend.h 49c25ea 
>   filters/libodfreader/OdfTextReaderBackend.cpp 30219ff 
>   filters/libodfreader/OdsReader.h PRE-CREATION 
>   filters/libodfreader/OdsReader.cpp PRE-CREATION 
>   filters/libodfreader/OdsReaderBackend.h PRE-CREATION 
>   filters/libodfreader/OdsReaderBackend.cpp PRE-CREATION 
>   filters/libodfreader/OdtReader.h 22ae935 
>   filters/libodfreader/OdtReader.cpp 48e1037 
>   filters/libodfreader/OdtReaderBackend.h ae321ab 
>   filters/libodfreader/OdtReaderBackend.cpp cdc59f1 
> 
> Diff: https://git.reviewboard.kde.org/r/122035/diff/
> 
> 
> Testing
> -------
> 
> Tested with extensive traces and existing filters that use the library.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150118/aff681cb/attachment.htm>