Review Request 122021: Kexi: Clicking "Go to new record" in tableview moves to first reasonable column

Adam Pigg adam at piggz.co.uk
Mon Jan 12 22:07:15 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122021/#review73891
-----------------------------------------------------------



kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp
<https://git.reviewboard.kde.org/r/122021/#comment51369>

    need to check for columnToSelect == -1 for case of 'all columns auto-inc' ?


- Adam Pigg


On Jan. 12, 2015, 9:59 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122021/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 9:59 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Clicking "Go to new record" in tableview now moves to first reasonable column. That means _first_ column that has no autoincrement flag set.
> Before it was the active column.
> 
> (this is a usability fix)
> 
> 
> Diffs
> -----
> 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp aeaf7175feed04568d55b6f0410c66d431a27060 
> 
> Diff: https://git.reviewboard.kde.org/r/122021/diff/
> 
> 
> Testing
> -------
> 
> Editable table views work
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150112/fa49f6e6/attachment.htm>


More information about the calligra-devel mailing list