Review Request 121830: Remove foreign elements before validating.

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121830/#review73676
-----------------------------------------------------------

Ship it!


Works for me for what I tested. And removeForeign.xsl seems to be okay from the little I remember about xsl :)

Please consider the two comments, and then ship it to calligra/2.9 branch (given master is frozen).


devtools/scripts/validateODF.py
<https://git.reviewboard.kde.org/r/121830/#comment51279>

    There are only two calls to `validateXML`, both omitting the `removeForeign` parameter.
    Please add a TODO what the plan for this third parameter is (who should call the method where with that set to `false`), or remove it to avoid dead code which makes understanding things only more complicate.



devtools/scripts/validateODF.py
<https://git.reviewboard.kde.org/r/121830/#comment51276>

    No by-drive whitespace fixes in unrelated parts, please.


- Friedrich W. H. Kossebau


On Jan. 4, 2015, 3:11 nachm., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121830/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 3:11 nachm.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Remove foreign elements before validating.
> 
> 
> Diffs
> -----
> 
>   devtools/scripts/removeForeign.xsl PRE-CREATION 
>   devtools/scripts/validateODF.py 61af3b5 
> 
> Diff: https://git.reviewboard.kde.org/r/121830/diff/
> 
> 
> Testing
> -------
> 
> In ODF 1.2 Extended, the use of foreign elements is allowed. Calligra does not save ODF 1.2, but ODF 1.2 Extended. The script is now updated to reflect this.
> 
> This means it will not fail on the use of attributes that uses namespaces outside of the ODF namepaces.
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150110/613f3645/attachment.htm>