Review Request 121938: Properly merge record navigator with horizontal scrollbar

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121938/#review73656
-----------------------------------------------------------

Ship it!


Looks good, and a net reduction in code!

- Adam Pigg


On Jan. 9, 2015, 12:12 a.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121938/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 12:12 a.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Properly merge geometry record navigator with horizontal scrollbar
> 
> This also fixes navigator updating on selecting another record (by mouse click or keyboard navigation).
> -- major defect #1 at https://community.kde.org/Kexi/Porting_to_Qt%26KDE_4#Table_View
> 
> + Do not display the scrollbar when not needed.
> + Remove related code that's no longer needed
> 
> 
> Diffs
> -----
> 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 97ee885a97744f35bfdd140488e8ac4414153d13 
>   kexi/widget/tableview/KexiTableScrollArea.h f4a2dfe13b51a4305b019ddd917a00015583e31f 
>   kexi/widget/tableview/KexiTableScrollArea.cpp d76097bb52d358fcd7430ab80857ba9617764a6f 
>   kexi/widget/utils/kexirecordnavigator.h a0cf2546c0dfd165f14b36005ac6cca5d2d72217 
>   kexi/widget/utils/kexirecordnavigator.cpp 0ce922a3ef2229cdefde032a1660de9fb05439c9 
>   kexi/core/KexiRecordNavigatorIface.h 5cf616f32584780311aa9b2c94e07274cc07272f 
>   kexi/plugins/forms/kexiformscrollview.h 82910f56147b01923e063fd25a694858d6f867dd 
>   kexi/plugins/forms/kexiformscrollview.cpp 4c563725a38381356013835a65ff02133c04c7eb 
>   kexi/plugins/forms/kexiformview.cpp 60c27e0ae4b0653e99dbdc209a072c51a90d620c 
>   kexi/plugins/reports/kexireportview.cpp 58d97052280f6aa048946edf43be40b470b343fd 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.h 74ab76f39005cc06f8889d67fff5a40304afba8f 
> 
> Diff: https://git.reviewboard.kde.org/r/121938/diff/
> 
> 
> Testing
> -------
> 
> Checked with tables/queries/forms/reports and various styles
> 
> 
> File Attachments
> ----------------
> 
> The navigator
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/806686d1-7680-434a-b2be-52a3b03a1275__d7AloPW.png
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150110/b6282a56/attachment.htm>