Review Request 121874: Improve major icons and introduce KexiIcon

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121874/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 7:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Improve major icons and introduce KexiIcon: icon name as understood by Kexi

These improvements prepare Kexi to be more attractive on Windows and Mac, I believe. See the screenshot.
Kexi 3 hopefully won't have to do most of this, but we never know.

Icon theme support is improved this way. The problem solved here is that for kdelibs4 oxygen is the default theme and cannot be overriden by app by just installing to ../share/apps/kexi/icons/THEMENAME/...
So breeze- prefix temporarily is used and theme is detected. Also quality of HighContrast-themed Kexi is improved this way.
Functions are used for some icon names instead of constants because names are computed.

Icons improved:
- database-import (temporarily re-use document-import for breeze)
- network-server-database (breeze)

Icons added:
- kexi-document-empty (made more concrete than document-new)
- kexi-file-database (replaces kexi-sqlite3 mime icon for breeze because the original is unreadable in our context, elsewhere mime icon still used)

Icons changed:
- use app-x-compress for 'compact' action


Diffs
-----

  kexi/pics/oxygen/32x32/actions/kexi-document-empty.svgz PRE-CREATION 
  kexi/pics/oxygen/32x32/places/breeze-kexi-file-database.svgz PRE-CREATION 
  kexi/pics/oxygen/32x32/actions/kexi-document-empty.png PRE-CREATION 
  kexi/pics/oxygen/16x16/places/breeze-network-server-database.svgz PRE-CREATION 
  kexi/pics/oxygen/22x22/actions/breeze-database-import.svgz PRE-CREATION 
  kexi/pics/oxygen/22x22/actions/breeze-kexi-document-empty.svgz PRE-CREATION 
  kexi/pics/oxygen/22x22/places/breeze-kexi-file-database.svgz PRE-CREATION 
  kexi/pics/oxygen/22x22/places/breeze-network-server-database.svgz PRE-CREATION 
  kexi/pics/oxygen/32x32/actions/breeze-kexi-document-empty.svgz PRE-CREATION 
  kexi/pics/oxygen/16x16/places/breeze-kexi-file-database.svgz PRE-CREATION 
  kexi/pics/hi48-action-database-import.png PRE-CREATION 
  kexi/pics/hi48-action-document_import_database.png da63b43b335691ee0df9569f727e4cf033b223ab 
  kexi/pics/hi22-action-document_import_database.png 18238ee33bf7e1785ab4f9e36003690f98aac27f 
  kexi/pics/hi32-action-database-import.png PRE-CREATION 
  kexi/pics/hi32-action-document_import_database.png dd9368984d0a3356144b8710d75e6eff56edcdf8 
  kexi/pics/hi16-action-database-import.png PRE-CREATION 
  kexi/pics/hi16-action-document_import_database.png e3a5398d452dc60e5fdc134f671c97d76aa256a7 
  kexi/pics/hi22-action-database-import.png PRE-CREATION 
  kexi/migration/importwizard.cpp 226561b92194e67fc49c0fcf3fe702eb5ebdac54 
  kexi/main/startup/KexiStartupDialog.cpp e5b13dcbb32d20a6b602d9d8f4d90ac6be1b604e 
  kexi/main/startup/KexiRecentProjectsModel.cpp 6eb1b296c41130b18928d33f8acab28e45e78ddf 
  kexi/main/KexiMainWindow.cpp e3bb54e42798efff0e05b387c88cc091c6b4ad67 
  kexi/main/startup/KexiNewProjectAssistant.cpp 4c7bf4842cdecc8e2694e58d8fb5c81247c6d409 
  kexi/main/startup/KexiOpenProjectAssistant.cpp 518098fa62a11cc1f57dcdd846a9918b894dec51 
  kexi/core/kexitemplateloader.cpp 0969f17c844c476c3184218211a16a71a650020d 
  kexi/core/kexi.cpp 65ad365a666ccd8b0e28e3d254c9c3b1defad9ed 
  kexi/core/kexi.h 10d27cc77aab3a072d5262648ab8b292e7418c11 
  libs/db/utils.h 2952c615ac1723e2e4ebf3230219e769f1b9bbaf 
  libs/db/utils.cpp b0704d30ce8e594e4911f97c6f05877b543dffd9 
  kexi/pics/oxygen/32x32/places/breeze-network-server-database.svgz PRE-CREATION 
  kexi/pics/oxygen/48x48/actions/kexi-document-empty.png PRE-CREATION 
  kexi/pics/oxygen/64x64/actions/kexi-document-empty.svgz PRE-CREATION 
  kexi/widget/KexiConnectionSelectorWidget.cpp 458c9a3322bb6063500872525c0631b315eceb57 
  kexi/widget/KexiProjectSelectorWidget.cpp ad01ee22e7437c4a21e3f4a7440c8d9338ac3ee9 
  kexi/widget/kexidbconnectionwidget.cpp 9f780efdda79e020344089e58e411ada38600bd1 
  kexi/widget/kexiprjtypeselector.cpp a331f0d39d3f956b4d87f26959cb85f2fb2be27c 
  kexi/widget/navigator/KexiProjectNavigator.cpp 2c0a536d7baa8cdf2778c0dc0df52749571f13a9 

Diff: https://git.reviewboard.kde.org/r/121874/diff/


Testing
-------

Checked oxygen, breeze, and a few other themes, plus all relevant GUIs


File Attachments
----------------

Welcome Screen with refreshed icons
  https://git.reviewboard.kde.org/media/uploaded/files/2015/01/05/252a3b9a-02cd-40d2-9584-143d401c2b71__kexi-2.9-breeze-icons.png


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150108/c84c4f25/attachment.htm>