Review Request 121598: Bug fix - 331483 : JJ Add "Flatten Layer" to the RightClick context menu

[Rishabh Saxena]

> On Dec. 23, 2014, 10:14 p.m., Sven Langkamp wrote:
> > Excluding the transparency mask from flatten isn't needed as it would automatically flatten the parent layer. There are also many other mask type that are not covered by this.
> 
> Dmitry Kazakov wrote:
>     I would expect this option would be available for layers only, not masks. It maight be rather unexpected when a parent is merged when there are many other siblings present. Thought excluding Transparency Mask only is not correct anyway, yes.
> 
> Rishabh Saxena wrote:
>     Hello,
>             What do you mean by "Many other siblings present".Are you talking about the sub-layers under the parent layer?

Hello,
       I have made the changes as u stated. Please have a look and review the same!!


- Rishabh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121598/#review72475
-----------------------------------------------------------


On Dec. 28, 2014, 12:28 p.m., Rishabh Saxena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121598/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2014, 12:28 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Bugs: 331483
>     http://bugs.kde.org/show_bug.cgi?id=331483
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Created a "Flatten layer" option in RightClick context menu using addActiontoMenu() method.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 1a8aabf 
>   krita/ui/kis_layer_manager.cc b609f42 
> 
> Diff: https://git.reviewboard.kde.org/r/121598/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rishabh Saxena
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150103/deab4037/attachment.htm>