Review Request 119368: Added shortcuts for performing actions on report's items in Kexi

[Wojciech Kosowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119368/#review76785
-----------------------------------------------------------



kexi/plugins/reports/kexireportdesignview.cpp
<https://git.reviewboard.kde.org/r/119368/#comment52854>

    here in constructors it is impossible to create slot as m_reportDesigner is created and deleted while changing views of report



kexi/plugins/reports/kexireportdesignview.cpp
<https://git.reviewboard.kde.org/r/119368/#comment52855>

    this is a place where m_reportDesigner is created therefore it is a perfect for creating slots as they will last until the instance of m_reportDesigner is deleted



libs/koreport/wrtembed/KoReportDesigner.cpp
<https://git.reviewboard.kde.org/r/119368/#comment52856>

    Take a look parent of the KStandardActions is pop is situated on stack. That means they are created and deleted each method call. It could be changed via creating some member pointer but in my opinion it would cause turmoil as for example all the actions would have to be removed. Still it's possible but I guess the solution above is the best one as it lasts the whole time the m_reportDesigner is alive


- Wojciech Kosowicz


On Feb. 28, 2015, 10:05 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119368/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2015, 10:05 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Bugs: 334967
>     http://bugs.kde.org/show_bug.cgi?id=334967
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Add basic shortcuts combination for copying, pasting, cutting deleting when deleting with report item
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportdesignview.cpp 1c83f53 
>   libs/koreport/wrtembed/KoReportDesigner.cpp adce325 
> 
> Diff: https://git.reviewboard.kde.org/r/119368/diff/
> 
> 
> Testing
> -------
> 
> QtSequence for Delete, Copy, Paste, Cut works when dealing with report item
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150228/cafca846/attachment.htm>