Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi
Wojciech Kosowicz
pcellix at gmail.com
Sat Feb 28 18:13:25 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/
-----------------------------------------------------------
(Updated Feb. 28, 2015, 6:13 p.m.)
Review request for Calligra, Adam Pigg and Jarosław Staniek.
Changes
-------
@staniek I guess I improved algorithm. The testcases from todo.kde.org passes
Repository: calligra
Description
-------
When hash sign (#) appears in csv file at the beginning of the line or in the middle of unqouted field
it is treated as the beginning of the comment and the following data is being ignored until the end of the row
Diffs (updated)
-----
kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd
kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4
libs/widgets/KoCsvImportDialog.cpp 8d042d7
kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4
kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285
Diff: https://git.reviewboard.kde.org/r/120940/diff/
Testing
-------
Able to activate/deactivate parsing comments. When activated able to choose specific sign
Thanks,
Wojciech Kosowicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150228/e4d99247/attachment.htm>
More information about the calligra-devel
mailing list