[Kexi-devel] RFC: plan for starting the Qt5/KF5 port

[C. Boemann]

On Wednesday 25 February 2015 10:18:19 Boudewijn Rempt wrote:
> On Wed, 25 Feb 2015, C. Boemann wrote:
> > On Wednesday 25 February 2015 10:01:16 Boudewijn Rempt wrote:
> >> > Applying full astyle is IMHO not OK, and even against efforts of
> >> > everyone who keeps eye on proper coding style while doing code
> >> > reviews.
> >> 
> >> Sorry, our current code base is a mess. I don't care about kexi, and I
> >> won't touch kexi. I won't touch any library except for pigment. But the
> >> mess we have with bracket placing, include styles, spaces around function
> >> arguments, initializer lists... It just needs cleaning up.
> > 
> > I'm not against cleaning up coding style, but any such commit should
> > follow
> > what we are practicing already, and not some half broken astyle. I have no
> > idea what astyle does and doesn't do, but i will not accept commits away
> > from our qt/kde style.
> > 
> > so show me that it doesn't mess up please
> 
> Check David's notes in kde-dev-scripts, please. That's what I was
> referring to. And sure I'll be careful.
Okay , I've read up on those, and on the astyle documentation. If astyle does 
what it intends then it looks nice and i would support running it. I have no 
issue with the history, it will be messed up anyway

Also didn't we talk about renaming classes as well?