[Kexi-devel] RFC: plan for starting the Qt5/KF5 port

[Dmitry Kazakov]

Hi!

My 2 cents :)

1) astyle

Last time astyle was applied to Krita code (something around 2010-2011, it
was applied partially?) I really didn't like the result. At least the thing
it did with braces and indentation. I guess we just need to choose really
carefully what to change and what not. E.g. one-line-return-if-error ifs
might not have braces. That is I don't agree that the policy statement "Use
curly braces even when the body of a conditional statement contains only
one line" should be followed blindly.

For the rest, e.g. include style, tab vs spaces, lines with trailing
whitespace I'm ok with fixing it automatically.

2) If astyle applied, it must be applied to master-only. Under no
circumstances to calligra/2.9. Without being able to use 'git blame' it'll
be tough to fix many kinds of bugs and do bisecting.

3) #pragma once

To tell you the truth I cannot remember a single case of facing a problem
with include guards for last several years. Why should we bother about any
non-standard compiler extensions then? My emacs scripts handle it quite
perfectly, I am pretty sure that QtCreator can also crack it. I just don't
understand the reasoning. Does MacOS compilers support it well enough?





On Wed, Feb 25, 2015 at 1:18 PM, Boudewijn Rempt <boud at valdyas.org> wrote:

> On Wed, 25 Feb 2015, C. Boemann wrote:
>
>  On Wednesday 25 February 2015 10:01:16 Boudewijn Rempt wrote:
>>
>>> > Applying full astyle is IMHO not OK, and even against efforts of
>>> > everyone who keeps eye on proper coding style while doing code
>>> > reviews.
>>>
>>> Sorry, our current code base is a mess. I don't care about kexi, and I
>>> won't touch kexi. I won't touch any library except for pigment. But the
>>> mess we have with bracket placing, include styles, spaces around function
>>> arguments, initializer lists... It just needs cleaning up.
>>>
>> I'm not against cleaning up coding style, but any such commit should
>> follow what we are practicing already, and not some half broken astyle. I
>> have no idea what astyle does and doesn't do, but i will not accept commits
>> away from our qt/kde style.
>>
>> so show me that it doesn't mess up please
>>
>>
> Check David's notes in kde-dev-scripts, please. That's what I was
> referring to. And sure I'll be careful.
>
> Boudewijn
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>



-- 
Dmitry Kazakov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150225/83cc91da/attachment.htm>