Review Request 121968: Krita: Refactoring of how KisActions are enabled and disabled
Scott Petrovic
scottpetrovic at gmail.com
Tue Feb 24 21:49:01 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121968/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:49 p.m.)
Status
------
This change has been discarded.
Review request for Calligra.
Repository: calligra
Description
-------
This fixes bugs related to closing documents and not having the associated actions disabled. This refactoring takes into account that when there are no views, most of the other flags and conditions should be ignored. Having a document open is a pre-requisite to having most of these flags set. That is the premise of the refactor
Diffs
-----
krita/ui/kis_action_manager.cpp 6e785bf
Diff: https://git.reviewboard.kde.org/r/121968/diff/
Testing
-------
Opening documents. Testing out different actions. Closing all documents testing actions. Opening up more documents, testing actions.
Ubuntu 14.04 mostly :/
Thanks,
Scott Petrovic
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150224/e89fb9cb/attachment.htm>
More information about the calligra-devel
mailing list