Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi

[Kamil Łysik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/#review76563
-----------------------------------------------------------



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52729>

    Please remove this comment if you are sure what argument should be passed.



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52730>

    "Comment sign" ?
    I think that there should be case like in sentences.



kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52731>

    I think that state switch from S_COMMENT to S_COMMENT does not make sense.



kexi/plugins/importexport/csv/kexicsvwidgets.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52734>

    I am not sure about this part. If we are using C++11, please use initialize list. If not, then I co not like that initialization using external constant as vector size. I can understand that default comment string may change, but please, think about this.
    
    tl;dr; this is not C.



kexi/plugins/importexport/csv/kexicsvwidgets.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52733>

    If you used "Hashtag", you can use "Double slash" to be consistent.



libs/widgets/KoCsvImportDialog.cpp
<https://git.reviewboard.kde.org/r/120940/#comment52738>

    Double empty line.


- Kamil Łysik


On Lut 23, 2015, 11:43 po południu, Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120940/
> -----------------------------------------------------------
> 
> (Updated Lut 23, 2015, 11:43 po południu)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> When hash sign (#) appears in csv file at the beginning of the line or in the middle of unqouted field
> it is treated as the beginning of the comment and the following data is being ignored until the end of the row
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoCsvImportDialog.cpp 8d042d7 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 
>   kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd 
>   kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 
>   libs/widgets/KoCsvImportDialog.h c64f15b 
> 
> Diff: https://git.reviewboard.kde.org/r/120940/diff/
> 
> 
> Testing
> -------
> 
> Able to activate/deactivate parsing comments. When activated able to choose specific sign
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150224/64bae0a1/attachment.htm>