Review Request 122698: Kexi maps choosing Map Theme Id.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122698/#review76535
-----------------------------------------------------------



plugins/reporting/maps/KoReportItemMaps.h
<https://git.reviewboard.kde.org/r/122698/#comment52705>

    - style
    - -> themeId()



plugins/reporting/maps/KoReportItemMaps.h
<https://git.reviewboard.kde.org/r/122698/#comment52704>

    -> m_themeProperty



plugins/reporting/maps/KoReportItemMaps.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52703>

    -> "report:theme"



plugins/reporting/maps/KoReportItemMaps.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52706>

    -> "theme"



plugins/reporting/maps/KoReportItemMaps.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52702>

    We cannot add new i18n in 2.9 anymore, please remove these args so "theme" will be visible to users.
    
    Then re-add i18n() in master.



plugins/reporting/maps/KoReportItemMaps.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52707>

    remove



plugins/reporting/maps/MapRenderer.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52708>

    Shouldn't this change be commited separately as it fixes something else?
    If so please commit this line outside of the review.



plugins/reporting/maps/MapRenderer.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52711>

    remove/comment out



plugins/reporting/maps/MapRenderer.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52709>

    remove/comment out



plugins/reporting/maps/MapRenderer.cpp
<https://git.reviewboard.kde.org/r/122698/#comment52710>

    Why here and not in MapRenderer()?


- Jarosław Staniek


On Feb. 23, 2015, 9:57 p.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122698/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 9:57 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek, Dimitrios Tanis, and Tomasz Olszak.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Kexi maps choosing Map Theme Id in reports.
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp d76b259720955304de9dd1f7819f9d2b0f630f2c 
>   plugins/reporting/maps/KoReportItemMaps.h 62eb15db4ef89502a1edbba6ee49cf85dd6521e9 
>   plugins/reporting/maps/KoReportItemMaps.cpp c29c0c51d17db8ce3f0c7e672e4d098e40a78f59 
>   plugins/reporting/maps/MapRenderer.cpp 687179c7fe4b1ae70fc31ab0566eab33fe6f7630 
> 
> Diff: https://git.reviewboard.kde.org/r/122698/diff/
> 
> 
> Testing
> -------
> 
> Maunual testing
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150224/d5ddd888/attachment.htm>