RFC: plan for starting the Qt5/KF5 port
Boudewijn Rempt
boud at valdyas.org
Tue Feb 24 09:04:46 GMT 2015
On Tue, 24 Feb 2015, Jaroslaw Staniek wrote:
> On 24 February 2015 at 09:47, Boudewijn Rempt <boud at valdyas.org> wrote:
>> Sorry, I have to interline in Jaroslaw's answer -- apparently I lost my
>> copies of the original mail, or they never arrived :-(
>>
>> As a sidenote, I also want to take the opportunity to do a clean-up step,
>> but I'm not sure what the right moment or place is. It might even something
>> to do in the 2.9 branch after tagging...
>
> Why not in master after everything compiles/runs?
Because we'll be continuing to fix bugs in 2.9. I did a test run of these
changes last week and tried to cherry-pick some patches and it was a big
failure. So I thought that having the changes in 2.9, too, would make
forward-porting of bug fixes easier.
>
>> * replace all header guards with '#pragma once' -- because errors with
>> header guards are actually quite frequent, and all compilers support this
>> pragma now.
>
> +1
>
>>
>> * rename all krita files to the calligra standard. (cc -> cpp, underscore ->
>> CamelCaps)
>
> Good one. If you ask me I'd rename it using filter-branch so the names
> look OK in history too.
> At least I'll consider this in frameworks that moved outside of calligra/.
>
>> * from kde-dev-scripts, run:
>> ** astyle-kdelibs (prevents the astyle problems with foreach and so on)
>
> For the record, astyle-kdelibs is broken (if fully applied) because
> astyle's options changed their meaning.
Well, that's why I specified following kde-dev-scripts, not just copy and
paste from techbase -- it's got instructions to patch astyle so it works
better.
> Discussed with someone and this is confirmed and big hope is that
> clang beautifier can be reused, no volunteers so far.
> I don't plan to apply to code I maintain, I wouldn't also want to read
> code (esp. libraries) that changed a lot because of style changes.
>
> (To be continued)
>
> --
> regards, Jaroslaw Staniek
>
> KDE:
> : A world-wide network of software engineers, artists, writers, translators
> : and facilitators committed to Free Software development - http://kde.org
> Calligra Suite:
> : A graphic art and office suite - http://calligra.org
> Kexi:
> : A visual database apps builder - http://calligra.org/kexi
> Qt Certified Specialist:
> : http://www.linkedin.com/in/jstaniek
> _______________________________________________
> calligra-devel mailing list
> calligra-devel at kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
More information about the calligra-devel
mailing list