Review Request 120940: Added parsing of hashtag comments inside imported csv in kexi

Wojciech Kosowicz pcellix at gmail.com
Sun Feb 22 23:08:20 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120940/
-----------------------------------------------------------

(Updated Lut 22, 2015, 11:08 po południu)


Review request for Calligra, Adam Pigg and Jarosław Staniek.


Changes
-------

This is more like a draft work. It still requires polishing up that I'll try to do soon. Still parsing works if someone has any comments, ideas how to improve, youre welcome


Repository: calligra


Description
-------

When hash sign (#) appears in csv file at the beginning of the line or in the middle of unqouted field
it is treated as the beginning of the comment and the following data is being ignored until the end of the row


Diffs (updated)
-----

  kexi/plugins/importexport/csv/kexicsvimportdialog.h 3dc3fe4 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 6572285 
  kexi/plugins/importexport/csv/kexicsvwidgets.h 1e87dbd 
  kexi/plugins/importexport/csv/kexicsvwidgets.cpp 3cf6ea4 
  libs/widgets/KoCsvImportDialog.h c64f15b 
  libs/widgets/KoCsvImportDialog.cpp 8d042d7 

Diff: https://git.reviewboard.kde.org/r/120940/diff/


Testing
-------

when importing csv it should distinct comments


Thanks,

Wojciech Kosowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150222/ac332e55/attachment.htm>


More information about the calligra-devel mailing list