Review Request 122656: Improve Kexi table view in combo box popups and spreadsheet mode

[Adam Pigg]

> On Feb. 21, 2015, 8:44 p.m., Adam Pigg wrote:
> > kexi/widget/tableview/KexiTableScrollArea.cpp, line 1673
> > <https://git.reviewboard.kde.org/r/122656/diff/1/?file=350479#file350479line1673>
> >
> >     Why this here?
> 
> Jarosław Staniek wrote:
>     I'd like to keep it there. As you know debugging focus/activation events is hard; this is one way to debug it -- by name.

what about wrapping such debuggin in an ifdef?


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122656/#review76408
-----------------------------------------------------------


On Feb. 20, 2015, 11:47 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122656/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 11:47 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Improve Kexi table view in combo box popups and spreadsheet mode
> 
> This mostly fixes table designer. Query designer needs some more work.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/tableview/KexiTableScrollArea.h 4c61c39352b947b6e655653804665de1d827f701 
>   kexi/widget/tableview/KexiTableScrollArea.cpp 0c9ff503bc859fe6290431692a3e277d618b61a4 
>   kexi/widget/tableview/KexiTableScrollArea_p.h ce1fb4a35d434565987de14f9a98eaf70a24c6ae 
>   kexi/widget/tableview/KexiTableScrollArea_p.cpp 1814a82a6f9fb79513c71a9d86a3dbe0ff11e825 
>   kexi/widget/tableview/kexicomboboxpopup.cpp c57918602418761279590878b664c665b5af3ec0 
>   kexi/widget/tableview/kexicomboboxtableedit.cpp bd28547190303f4e6fdd73638e1bdb3baa880a50 
>   kexi/plugins/tables/kexitabledesignerview.cpp c09b7ec76657abc3f8be0edbfd0717c89cbcf2e2 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.h b73ae64a6f2eef7e96989b749e6535e9e5efdcc6 
>   kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 05c5b5549b889f827a604baddf29d4753d7addd3 
>   kexi/formeditor/connectiondialog.cpp 28b5fb61804b38680120d771ce5819c5a7a274c5 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp c482a149a61f19e2d37e7e48a489fbe0c8096dea 
> 
> Diff: https://git.reviewboard.kde.org/r/122656/diff/
> 
> 
> Testing
> -------
> 
> Table designer tested, including adding/removing rows and showing combo boxes
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150221/48705856/attachment.htm>