Review Request 122645: Multiple map rendering on one report.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122645/#review76336
-----------------------------------------------------------

Ship it!


Good job\!
\- add BUG:336986
\- I think HttpDownloadManager.h is added here by accident? If so, please remove. If not, please explain.
\- change the commit msg to: Support multiple maps on a single Kexi report


plugins/reporting/maps/KoReportItemMaps.h
<https://git.reviewboard.kde.org/r/122645/#comment52599>

    remove the line


- Jarosław Staniek


On Feb. 20, 2015, 2:44 p.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122645/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2015, 2:44 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Jarosław Staniek, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Hide NavigationFloatItem on rendered maps
> 
> Due marble bug, maps data have to be in cache. if there are wrong data on your report (usually there's only ocean on the map), close it and reopen, then data should be shown properly.
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/maps/KoReportItemMaps.h e2840994f85d1b8c875cf63fbcd4b5fb860de16a 
>   plugins/reporting/maps/KoReportItemMaps.cpp 9e53753d738ee29ea4ed32f583cbe7ea1b632c8f 
>   plugins/reporting/maps/MapRenderer.h PRE-CREATION 
>   plugins/reporting/maps/MapRenderer.cpp PRE-CREATION 
>   plugins/reporting/maps/marble/HttpDownloadManager.h PRE-CREATION 
>   plugins/reporting/maps/CMakeLists.txt 40ed593769d05d70f4a597f8ddf039086be1ae7c 
> 
> Diff: https://git.reviewboard.kde.org/r/122645/diff/
> 
> 
> Testing
> -------
> 
> Manual testing,
> works on cached data.
> If data have to be loaded, partially renderd maps are displayed.
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150220/af8c3b88/attachment.htm>