Review Request 122633: Checkbox to hide/show color selector in the Advanced color selector docker

[Ranveer Aggarwal]

> On Feb. 18, 2015, 8 p.m., Boudewijn Rempt wrote:
> > Hm, I'm not sure this is quite what the reported wanted -- if I uncheck "show color selector" the shade selector is gone, too, and that should still be visible.

If you see Comment#5 and Comment#8 on that bug, I guess what the OP wanted was for both to go away on clicking a checkbox. I can hide just the color selector without changing much I suppose.


- Ranveer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122633/#review76255
-----------------------------------------------------------


On Feb. 18, 2015, 5:58 p.m., Ranveer Aggarwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122633/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2015, 5:58 p.m.)
> 
> 
> Review request for Calligra, Boudewijn Rempt and Wolthera van Hövell.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix to Bug 337328 - Advanced color selector do not allow to show Shade selector only
> 
> 
> Diffs
> -----
> 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.h 8296984 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_container.cpp 87dfb5d 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ng_docker_widget.cpp 7a7c7af 
>   krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_settings.cpp 0097d05 
>   krita/plugins/extensions/dockers/advancedcolorselector/wdg_color_selector_settings.ui b4ab71a 
> 
> Diff: https://git.reviewboard.kde.org/r/122633/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ranveer Aggarwal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150218/604c90dd/attachment.htm>