-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122559/#review76223
-----------------------------------------------------------
Good job.
kexi/core/KexiMainWindowIface.h
<https://git.reviewboard.kde.org/r/122559/#comment52550>
queryId -> identifier
And add docs:
//! \return query schema currently unsaved (edited) in a window corresponding to Kexi object identified by \a identifier.
/*! For implementation in plugins, default implementation returns 0. In implementations 0 should be returned if there is no such Kexi object in the current project or if the object's window is not opened or if the window contains no edited query at the moment. If the query is "unsaved" the window displaying the corresponding Kexi object is marked as "dirty".
Currently supported type of Kexi objects are only queries being in data view. See KexiQueryPart::unsavedQuery(int) for this implementation.
The query schema returned by this method can be used for example by data exporting routines so users can export result of running unsaved query without prior saving its design. The changes to design can be even discarded without consequences this way.
@note Returned pointer leads to a temporary query schema object owned by the corresponding view, so lifetime of the object is limited to the lifetime of the view and its window. Do not store the pointer after the window is closed to avoid dangling pointers.
\see KexiPart::Part::currentQuery(KexiView*) KexiWindow::isDirty()
*/
kexi/main/KexiMainWindow.h
<https://git.reviewboard.kde.org/r/122559/#comment52563>
1. Make the method const
2. Docs -->
/*! Shows a question message "Design of query %1 that you want to export data from is changed and has not yet been saved. Do you want to use data from the changed query for exporting or from its original (saved) version?"
\return true if the user picked the first option, false if the user picked the second option and cancelled value if user cancelled the export.
kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52551>
use 0 as recommended for C++
kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52558>
do we want to always insert this?
kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52560>
t -> result
kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52557>
useTempQuery != 0
(cleaner, since useTempQuery isn't a bool)
kexi/plugins/queries/kexiquerypart.h
<https://git.reviewboard.kde.org/r/122559/#comment52549>
add
//! Implemented for KexiPart::Part.
kexi/plugins/queries/kexiquerypart.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52546>
->qobject_cast
kexi/plugins/queries/kexiquerypart.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52547>
indent
kexi/plugins/queries/kexiquerypart.cpp
<https://git.reviewboard.kde.org/r/122559/#comment52545>
one line too much
- Jarosław Staniek
On Feb. 18, 2015, 11:01 a.m., Roman Shtemberko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122559/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:01 a.m.)
>
>
> Review request for Calligra, Adam Pigg, Jarosław Staniek, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Message is being displayed If design of query being exported is dirty. Also window with query is opened (without switching views) on export.
>
>
> Diffs
> -----
>
> kexi/core/KexiMainWindowIface.h 2798198
> kexi/core/kexipart.h e320434
> kexi/core/kexipart.cpp ca70942
> kexi/main/KexiMainWindow.h 628fb22
> kexi/main/KexiMainWindow.cpp 3ae1eac
> kexi/migration/importtablewizard.cpp 632fed8
> kexi/plugins/importexport/csv/CMakeLists.txt 9d40ce6
> kexi/plugins/importexport/csv/kexicsvexport.h 280b33f
> kexi/plugins/importexport/csv/kexicsvexport.cpp dfe107d
> kexi/plugins/importexport/csv/kexicsvexportwizard.cpp 096ea71
> kexi/plugins/queries/kexiquerypart.h 09491f5
> kexi/plugins/queries/kexiquerypart.cpp ce7548e
>
> Diff: https://git.reviewboard.kde.org/r/122559/diff/
>
>
> Testing
> -------
>
> Work with both exports (to file/clipboard).
>
>
> Thanks,
>
> Roman Shtemberko
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150218/b9cb5c09/attachment.htm>