Review Request 122584: Use shared pointers for markers.

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122584/#review76230
-----------------------------------------------------------

Ship it!


I really want this fix to go in. Unless we get another patch in time for the release, this at least fixes the crash.

- Boudewijn Rempt


On Feb. 16, 2015, 1:26 a.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122584/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 1:26 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 343719
>     http://bugs.kde.org/show_bug.cgi?id=343719
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Use shared pointers for markers.
> Currently markers crash Krita on close (bug 343719). The problem is that existing path shapes point to the marker even after it's deleted. The patch solves that by using shared pointers for the marker.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoMarkerData.cpp 247e151 
>   libs/flake/KoMarker.h fa2adfd 
>   libs/flake/KoMarkerCollection.h 1555363 
>   libs/flake/KoMarkerCollection.cpp 98e80f8 
> 
> Diff: https://git.reviewboard.kde.org/r/122584/diff/
> 
> 
> Testing
> -------
> 
> Tested with Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150218/f355641c/attachment.htm>