Review Request 122584: Use shared pointers for markers.

[Sven Langkamp]

> On Feb. 16, 2015, 10:11 vorm., Inge Wallin wrote:
> > Wouldn't a much better solution be to make the Private class of the KoMarker shared? If so, we could have the collection store KoMarkers instead of a collection of KoMarker*s. Making KoMarker itself a QSharedData feels very strange and is different than anything else in Calligra.

That would not work. There is only one marker object in the marker collection and everything else just refers by pointers. Internal reference count would always be 1.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122584/#review76108
-----------------------------------------------------------


On Feb. 16, 2015, 1:26 vorm., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122584/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 1:26 vorm.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 343719
>     http://bugs.kde.org/show_bug.cgi?id=343719
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Use shared pointers for markers.
> Currently markers crash Krita on close (bug 343719). The problem is that existing path shapes point to the marker even after it's deleted. The patch solves that by using shared pointers for the marker.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoMarkerData.cpp 247e151 
>   libs/flake/KoMarker.h fa2adfd 
>   libs/flake/KoMarkerCollection.h 1555363 
>   libs/flake/KoMarkerCollection.cpp 98e80f8 
> 
> Diff: https://git.reviewboard.kde.org/r/122584/diff/
> 
> 
> Testing
> -------
> 
> Tested with Krita.
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150216/87812200/attachment.htm>