Review Request 122584: Use shared pointers for markers.

Sven Langkamp sven.langkamp at gmail.com
Mon Feb 16 01:26:02 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122584/
-----------------------------------------------------------

Review request for Calligra.


Bugs: 343719
    http://bugs.kde.org/show_bug.cgi?id=343719


Repository: calligra


Description
-------

Use shared pointers for markers.
Currently markers crash Krita on close (bug 343719). The problem is that existing path shapes point to the marker even after it's deleted. The patch solves that by using shared pointers for the marker.


Diffs
-----

  libs/flake/KoMarkerData.cpp 247e151 
  libs/flake/KoMarker.h fa2adfd 
  libs/flake/KoMarkerCollection.h 1555363 
  libs/flake/KoMarkerCollection.cpp 98e80f8 

Diff: https://git.reviewboard.kde.org/r/122584/diff/


Testing
-------

Tested with Krita.


Thanks,

Sven Langkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150216/98078d4c/attachment.htm>


More information about the calligra-devel mailing list