Review Request 122197: Fixes to .ods import

[Jarosław Staniek]

> On Feb. 7, 2015, 12:47 a.m., Jarosław Staniek wrote:
> > kexi/main/KexiMainWindow.cpp, line 3507
> > <https://git.reviewboard.kde.org/r/122197/diff/3-5/?file=347137#file347137line3507>
> >
> >     These 3 lines can be replaced by
> >     
> >     QString destinationTableName(args["destinationTableName"]);
> >     if (!destinationTableName.isEmpty()) {

I said "3 lines" :) -- args.contains("destinationTableName") is no longer needed :)


> On Feb. 7, 2015, 12:47 a.m., Jarosław Staniek wrote:
> > kexi/migration/AlterSchemaTableModel.cpp, line 28
> > <https://git.reviewboard.kde.org/r/122197/diff/5/?file=347258#file347258line28>
> >
> >     3 -> ROWS_FOR_PREVIEW
> 
> Roman Shtemberko wrote:
>     you mean define new ROWS_FOR_PREVIEW in AlterSchemaTableModel.cpp, right?

Right, said it short as for smart people :)


> On Feb. 7, 2015, 12:47 a.m., Jarosław Staniek wrote:
> > kexi/migration/AlterSchemaWidget.cpp, line 84
> > <https://git.reviewboard.kde.org/r/122197/diff/5/?file=347260#file347260line84>
> >
> >     Ah this still crases, please revert and see ctor.
> 
> Roman Shtemberko wrote:
>     do you mean dtor, not a ctor?

Yes, sorry. Some reasoning: by deleting table first we make sure any events or signals are consumed and by the time when we delete model, nobody consumes its contents.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122197/#review75550
-----------------------------------------------------------


On Feb. 9, 2015, 2:46 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122197/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 2:46 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 336815
>     http://bugs.kde.org/show_bug.cgi?id=336815
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix 336815 (path issue)
> Also have fixed with this patch:
> Check for an empty name.
> Names are no more converted to the lower case (there is some conflicts with this behavior, imported tables can not be opened after this (only after restarting an app (!?)))
> Check if name is not starting with a digit (conflicts with '_' at the begining as well).
> Default name is added based on sheet selected.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp f499951 
>   kexi/migration/AlterSchemaTableModel.h 2090b35 
>   kexi/migration/AlterSchemaTableModel.cpp 86ef62e 
>   kexi/migration/AlterSchemaWidget.h b29e7f9 
>   kexi/migration/AlterSchemaWidget.cpp ea7fedd 
>   kexi/migration/importtablewizard.h a0b4dca 
>   kexi/migration/importtablewizard.cpp f3d02b9 
>   kexi/plugins/migration/keximigrationpart.cpp 03c674e 
>   kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e 
> 
> Diff: https://git.reviewboard.kde.org/r/122197/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150212/b2b5a360/attachment.htm>