Review Request 122197: Fixes to .ods import

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122197/#review75936
-----------------------------------------------------------


Great, minor fixes left!


Also please fix trailing whitespaces, easy way: in your calligra*/.git/hooks/ dir:

chmod +x pre-commit

then on commit there you'd see:


* You have some suspicious patch lines:
*
* In kexi/migration/AlterSchemaWidget.h
* trailing whitespace (line 79)
kexi/migration/AlterSchemaWidget.h:79: 

etc.


kexi/migration/AlterSchemaWidget.h
<https://git.reviewboard.kde.org/r/122197/#comment52394>

    "inline bool nameExists() const" not defined and not used.



kexi/migration/AlterSchemaWidget.cpp
<https://git.reviewboard.kde.org/r/122197/#comment52397>

    -> newCaption
    -(avoid misleading name)



kexi/migration/importtablewizard.cpp
<https://git.reviewboard.kde.org/r/122197/#comment52398>

    filenbame - > filename (my typo, sorry)


- Jarosław Staniek


On Feb. 9, 2015, 2:46 p.m., Roman Shtemberko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122197/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 2:46 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 336815
>     http://bugs.kde.org/show_bug.cgi?id=336815
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix 336815 (path issue)
> Also have fixed with this patch:
> Check for an empty name.
> Names are no more converted to the lower case (there is some conflicts with this behavior, imported tables can not be opened after this (only after restarting an app (!?)))
> Check if name is not starting with a digit (conflicts with '_' at the begining as well).
> Default name is added based on sheet selected.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp f499951 
>   kexi/migration/AlterSchemaTableModel.h 2090b35 
>   kexi/migration/AlterSchemaTableModel.cpp 86ef62e 
>   kexi/migration/AlterSchemaWidget.h b29e7f9 
>   kexi/migration/AlterSchemaWidget.cpp ea7fedd 
>   kexi/migration/importtablewizard.h a0b4dca 
>   kexi/migration/importtablewizard.cpp f3d02b9 
>   kexi/plugins/migration/keximigrationpart.cpp 03c674e 
>   kexi/widget/KexiConnectionSelectorWidget.cpp 48d3f7e 
> 
> Diff: https://git.reviewboard.kde.org/r/122197/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Shtemberko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150212/627bfaaf/attachment.htm>