Review Request 122114: [OS X] adaptations of the build system (CMake files) to MacPorts

[Friedrich W. H. Kossebau]

> On Jan. 20, 2015, 9:09 nachm., Friedrich W. H. Kossebau wrote:
> > cmake/modules/FindOpenJPEG.cmake, line 32
> > <https://git.reviewboard.kde.org/r/122114/diff/5/?file=343906#file343906line32>
> >
> >     Is this really needed? Does it not work without?
> >     
> >     From how I understood the docs, "<prefix>/lib for each <prefix> in CMAKE_SYSTEM_PREFIX_PATH" will be tried, so no need to list this suffix here again explicitely.
> >     If it does not work, please add a comment to this line why it is needed.
> 
> René J.V. Bertin wrote:
>     It looks a bit strange to have a `PATH_SUFFIXES` line without any suffixes following it, but it seems to work.

Good, thanks for testing. So just drop the `PATH_SUFFIXES` line/argument, if no suffixes need to be added :)


> On Jan. 20, 2015, 9:09 nachm., Friedrich W. H. Kossebau wrote:
> > cmake/modules/FindVc.cmake, line 33
> > <https://git.reviewboard.kde.org/r/122114/diff/5/?file=343908#file343908line33>
> >
> >     This suffix seems strange to me, but then I have no clue. Did you try if it works without?
> >     And if needed, please add a comment where it is needed for, so it could be revisited later.
> 
> René J.V. Bertin wrote:
>     See above; works without.

Good. So in the end no need for any change to this file, right? So it would be only reformatting the code, and that is not really needed.
Thus just drop this file from the patch.


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122114/#review74438
-----------------------------------------------------------


On Feb. 5, 2015, 1:45 nachm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122114/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 1:45 nachm.)
> 
> 
> Review request for Calligra and KDE Software on Mac OS X.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch adapts the build system to OS X with KDE4, Qt4 and other dependencies installed through MacPorts. 
> 
> In order of appearance in the patch file:
> - `-DQT_EXCEPTIONS`: this is for use with Qt built with its -no-exceptions option, which MacPorts provides as an optional variant.
> - Newer OS X variants only provide the clang compiler
> - The default install location for MacPorts is `/opt/local`, but this can be changed by the user. The header and library search paths required for OpenJPEG, libpqxx and OpenVC are added using `//opt//local//` which is of course equivalent to `/opt/local` but easier to search-and-replace with the true install location in MacPorts' post-patch stage.
> - the product set for OS X has been extended to all applications and features that build and make sense. (Calligra Gemini builds, but does not function properly.)
> 
> A "Portfile" and accompanying patches that don't have the vocation to be included "upstream" in calligra will be uploaded to MacPorts' trac system soon.
> 
> 
> Diffs
> -----
> 
>   cmake/productsets/osx.cmake 1fe8f1c 
>   CMakeLists.txt facb5f9 
>   cmake/modules/FindOpenJPEG.cmake 6bfd93c 
>   cmake/modules/FindPqxx.cmake 3e24a0c 
>   cmake/modules/FindVc.cmake bb9823f 
> 
> Diff: https://git.reviewboard.kde.org/r/122114/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6 installed through MacPorts.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20150206/994d81a6/attachment.htm>